fix(Field): id generation #824
Conversation
🦋 Changeset detectedLatest commit: 09e4796 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-a2b7e68. |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| return result as Props; | ||
| } | ||
| return props; | ||
| } |
There was a problem hiding this comment.
Bug: Standalone Fields Lack Proper Label Linking
Standalone fields (without a name prop) with an explicitly provided id prop do not automatically get labelProps.for set to match their id. This breaks label-input accessibility linking and contradicts documented behavior.
Note
Generate IDs and label-for links for standalone fields via useFieldProps; remove per-component ID wiring and stop
formprop leaking to the DOM across inputs.useFieldProps: for fields withoutname, generateidviauseId()and setlabelProps.for; avoiduseFieldin this mode. For form-connected fields, keep existing logic.FieldBaseProps: addformprop.src/components/form/Claude.md.useId()/manuallabelProps.forand rely onprops.idfromuseFieldPropsinComboBox,FilterListBox,FilterPicker,ListBox.formto avoid passing it to DOM in many inputs (Checkbox,CheckboxGroup,ComboBox,FileInput,FilterListBox,FilterPicker,LegacyComboBox,ListBox,Radio,RadioGroup,Select,SliderBase,Switch,TextInputBase,TextInputMapper).Switch: generate stableidand wireHiddenInput/label via thatid.TextInputBase: stop rendering theformattribute on the native input.Written by Cursor Bugbot for commit 09e4796. This will update automatically on new commits. Configure here.