fix(Select): description prop leakage #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c825a99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
solarrust
approved these changes
Nov 7, 2025
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-9bee06e. |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
🧪 Storybook is successfully deployed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Renames the Select trigger prop from
descriptiontotriggerDescriptionand wires it through to the trigger to stop prop leakage, updating docs accordingly.src/components/fields/Select/Select.tsx)descriptionprop withtriggerDescriptioninCubeSelectBasePropsand usage.triggerDescriptiontoSelectTriggerasdescription.src/components/fields/Select/Select.docs.mdx)descriptiontotriggerDescription.@cube-dev/ui-kitdescribing the prop change and leakage fix.Written by Cursor Bugbot for commit c825a99. This will update automatically on new commits. Configure here.