a bit optimized version

Author: KSDaemon

packages/cubejs-backend-native/src/node_export.rs

@@ -510,15 +510,15 @@ fn debug_js_to_clrepr_to_js(mut cx: FunctionContext) -> JsResult<JsValue> {
 
 fn parse_cubestore_ws_result_message(mut cx: FunctionContext) -> JsResult<JsValue> {
     let msg = cx.argument::<JsBuffer>(0)?;
-    let msg_data = msg.as_slice(&cx);
-    match parse_cubestore_ws_result(msg_data) {
+    let msg_data = msg.as_slice(&cx).to_vec();
+    match parse_cubestore_ws_result(&*msg_data) {
         Ok(result) => {
             let js_array = JsArray::new(&mut cx, result.len());
             for (i, row) in result.into_iter().enumerate() {
                 let js_row = JsObject::new(&mut cx);
                 for (key, value) in row.into_iter() {
-                    let js_key = cx.string(&key);
-                    let js_value = cx.string(&value);
+                    let js_key = cx.string(key);
+                    let js_value = cx.string(value);
                     js_row.set(&mut cx, js_key, js_value)?;
                 }
                 js_array.set(&mut cx, i as u32, js_row)?;

rust/cubeorchestrator/src/cubestore_message_parser.rs

@@ -30,7 +30,7 @@ impl std::error::Error for ParseError {}
 
 pub fn parse_cubestore_ws_result(
     msg_data: &[u8],
-) -> Result<Vec<HashMap<String, String>>, ParseError> {
+) -> Result<Vec<HashMap<&str, &str>>, ParseError> {
     let http_message =
         root_as_http_message(msg_data).map_err(|_| ParseError::FlatBufferError)?;
 
@@ -57,7 +57,7 @@ pub fn parse_cubestore_ws_result(
                 if column.is_empty() {
                     return Err(ParseError::ColumnNameNotDefined);
                 }
-                columns.push(column.to_string());
+                columns.push(column);
             }
 
             let result_set_rows = result_set.rows().ok_or(ParseError::EmptyResultSet)?;
@@ -69,7 +69,7 @@ pub fn parse_cubestore_ws_result(
 
                 for (i, val) in values.iter().enumerate() {
                     let value = val.string_value().ok_or(ParseError::ColumnValueMissed)?;
-                    row_obj.insert(columns[i].clone(), value.to_string());
+                    row_obj.insert(columns[i], value);
                 }
 
                 result.push(row_obj);