chore(cubesql): PowerBI min max test

Author: paveltiunov

packages/cubejs-backend-shared/src/env.ts

@@ -1544,7 +1544,7 @@ const variables: Record<string, (...args: any) => any> = {
     .default('5000')
     .asInt(),
   allowUngroupedWithoutPrimaryKey: () => get('CUBEJS_ALLOW_UNGROUPED_WITHOUT_PRIMARY_KEY')
-    .default('false')
+    .default(get('CUBESQL_SQL_PUSH_DOWN').default('false').asString())
     .asBoolStrict(),
   redisPassword: () => {
     const redisPassword = get('CUBEJS_REDIS_PASSWORD')

packages/cubejs-testing/birdbox-fixtures/postgresql/schema/Orders.js

@@ -1,14 +1,14 @@
 cube(`Orders`, {
   sql: `
-  select 1 as id, 100 as amount, 'new' status
+  select 1 as id, 100 as amount, 'new' status, '2024-01-01'::timestamptz created_at
   UNION ALL
-  select 2 as id, 200 as amount, 'new' status
+  select 2 as id, 200 as amount, 'new' status, '2024-01-02'::timestamptz created_at
   UNION ALL
-  select 3 as id, 300 as amount, 'processed' status
+  select 3 as id, 300 as amount, 'processed' status, '2024-01-03'::timestamptz created_at
   UNION ALL
-  select 4 as id, 500 as amount, 'processed' status
+  select 4 as id, 500 as amount, 'processed' status, '2024-01-04'::timestamptz created_at
   UNION ALL
-  select 5 as id, 600 as amount, 'shipped' status
+  select 5 as id, 600 as amount, 'shipped' status, '2024-01-05'::timestamptz created_at
   `,
   measures: {
     count: {
@@ -23,9 +23,20 @@ cube(`Orders`, {
     },
   },
   dimensions: {
+    id: {
+      sql: `id`,
+      type: `number`,
+      primaryKey: true,
+    },
+
     status: {
       sql: `status`,
       type: `string`,
     },
+
+    createdAt: {
+      sql: `created_at`,
+      type: `time`
+    }
   },
 });

packages/cubejs-testing/birdbox-fixtures/postgresql/schema/SecurityContextTest.js

@@ -20,6 +20,7 @@ cube(`SecurityContextTest`, {
     uid: {
       sql: `uid`,
       type: `string`,
+      primaryKey: true,
     },
   },
 });

packages/cubejs-testing/test/__snapshots__/smoke-cubesql.test.ts.snap

@@ -16,3 +16,12 @@ Array [
   },
 ]
 `;
+
+exports[`SQL API Postgres (Data) powerbi min max push down: powerbi_min_max_push_down 1`] = `
+Array [
+  Object {
+    "a0": 2024-01-05T00:00:00.000Z,
+    "a1": 2024-01-01T00:00:00.000Z,
+  },
+]
+`;

packages/cubejs-testing/test/smoke-cubesql.test.ts

@@ -61,6 +61,7 @@ describe('SQL API', () => {
         CUBEJS_DB_PASS: 'test',
         //
         CUBEJS_PG_SQL_PORT: `${pgPort}`,
+        CUBESQL_SQL_PUSH_DOWN: 'true',
       },
       {
         schemaDir: 'postgresql/schema',
@@ -163,5 +164,21 @@ describe('SQL API', () => {
       const res = await connection.query('SELECT COUNT(*) as cn, "status" FROM Orders GROUP BY 2 ORDER BY cn DESC');
       expect(res.rows).toMatchSnapshot('sql_orders');
     });
+
+    test('powerbi min max push down', async () => {
+      const res = await connection.query(`
+      select
+  max("rows"."createdAt") as "a0",
+  min("rows"."createdAt") as "a1"
+from
+  (
+    select
+      "createdAt"
+    from
+      "public"."Orders" "$Table"
+  ) "rows"
+  `);
+      expect(res.rows).toMatchSnapshot('powerbi_min_max_push_down');
+    });
   });
 });