Skip to content

Commit c3ca3c4

Browse files
authored
chore(cubesql): Clean up unreferenced insta snapshots (#9130)
* chore(cubesql): Clean up unreferenced insta snapshots * ci(cubesql): Check unreferenced insta snapshots in CI * try to combine llvm-cov and insta test run
1 parent 622b266 commit c3ca3c4

File tree

41 files changed

+10
-751
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+10
-751
lines changed

.github/workflows/rust-cubesql.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,11 @@ jobs:
8585
with:
8686
crate: cargo-llvm-cov
8787
version: "0.6.10"
88+
- name: Install [email protected]
89+
uses: baptiste0928/cargo-install@v3
90+
with:
91+
crate: cargo-insta
92+
version: "1.42.0"
8893
- name: Unit tests (Rewrite Engine)
8994
env:
9095
CUBESQL_TESTING_CUBE_TOKEN: ${{ secrets.CUBESQL_TESTING_CUBE_TOKEN }}
@@ -94,7 +99,11 @@ jobs:
9499
CUBESQL_REWRITE_TIMEOUT: 60
95100
run: |
96101
cd rust/cubesql
97-
cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info
102+
# See https://github.com/taiki-e/cargo-llvm-cov/blob/main/README.md#get-coverage-of-external-tests
103+
# shellcheck source=/dev/null
104+
source <(cargo llvm-cov show-env --export-prefix)
105+
cargo insta test --all-features --workspace --unreferenced reject
106+
cargo llvm-cov report --lcov --output-path lcov.info
98107
- name: Upload code coverage
99108
uses: codecov/codecov-action@v5
100109
with:

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__current_schemas_including_implicit_postgres.snap

Lines changed: 0 additions & 10 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__current_schemas_postgres.snap

Lines changed: 0 additions & 10 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__explain_table.snap

Lines changed: 0 additions & 25 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__information_schema_columns.snap

Lines changed: 0 additions & 21 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__pg_catalog_generate_series_i64.snap

Lines changed: 0 additions & 13 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__pg_datetime_precision_types.snap

Lines changed: 0 additions & 103 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__pg_expandarray_index.snap

Lines changed: 0 additions & 24 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__pg_generate_subscripts_1.snap

Lines changed: 0 additions & 15 deletions
This file was deleted.

rust/cubesql/cubesql/src/compile/snapshots/cubesql__compile__tests__pg_generate_subscripts_2_forward.snap

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)