chore(query-orchestrator): Get rid fetchSchema (#6423)

Author: wolfeeeg

packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts

@@ -431,7 +431,6 @@ export class QueryCache {
       lambdaTypes,
       persistent,
       aliasNameToMember,
-      tablesSchema,
     }: {
       cacheKey: CacheKey,
       dataSource: string,
@@ -443,7 +442,6 @@ export class QueryCache {
       lambdaTypes?: TableStructure,
       persistent?: boolean,
       aliasNameToMember?: { [alias: string]: string },
-      tablesSchema?: boolean,
     }
   ) {
     const queue = external
@@ -458,7 +456,6 @@ export class QueryCache {
       inlineTables,
       useCsvQuery,
       lambdaTypes,
-      tablesSchema,
     };
 
     const opt = {
@@ -487,8 +484,6 @@ export class QueryCache {
             this.logger('Executing SQL', { ...req });
             if (req.useCsvQuery) {
               return this.csvQuery(client, req);
-            } else if (req.tablesSchema) {
-              return client.tablesSchema();
             } else {
               return client.query(req.query, req.values, req);
             }
@@ -555,10 +550,6 @@ export class QueryCache {
         `SQL_QUERY_EXT_${this.redisPrefix}`,
         this.options.externalDriverFactory,
         (client, q) => {
-          if (q.tablesSchema) {
-            return client.tablesSchema();
-          }
-
           this.logger('Executing SQL', {
             ...q
           });

packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts

@@ -481,13 +481,4 @@ export class QueryOrchestrator {
   public async updateRefreshEndReached() {
     return this.preAggregations.updateRefreshEndReached();
   }
-
-  public async fetchSchema(dataSource?: string, external?: boolean) {
-    return this.queryCache.queryWithRetryAndRelease('', [], {
-      cacheKey: [`Fetch schema for ${dataSource}`, []],
-      dataSource,
-      external,
-      tablesSchema: true
-    });
-  }
 }

packages/cubejs-query-orchestrator/test/unit/QueryOrchestrator.test.js

@@ -117,19 +117,15 @@ class MockDriver {
   capabilities() {
     return {};
   }
-  
-  tablesSchema() {
-    return this.schemaData;
-  }
 
   async streamQuery(sql) {
     return Readable.from((await this.query(sql)).map(r => (typeof r === 'string' ? { query: r } : r)));
   }
 }
 
 class ExternalMockDriver extends MockDriver {
-  constructor({ schemaData } = {}) {
-    super({ schemaData });
+  constructor() {
+    super();
     this.indexes = [];
     this.csvFiles = [];
   }
@@ -223,7 +219,7 @@ describe('QueryOrchestrator', () => {
     const csvMockDriverLocal = new MockDriver({ csvImport: 'true' });
     const mockDriverUnloadWithoutTempTableSupportLocal = new MockDriverUnloadWithoutTempTableSupport();
     const streamingSourceMockDriverLocal = new StreamingSourceMockDriver();
-    const externalMockDriverLocal = new ExternalMockDriver({ schemaData });
+    const externalMockDriverLocal = new ExternalMockDriver();
 
     const redisPrefix = `ORCHESTRATOR_TEST_${testCount++}`;
     const driverFactory = (dataSource) => {
@@ -1636,11 +1632,6 @@ describe('QueryOrchestrator', () => {
     expect(mockDriver.tables).toContainEqual(expect.stringMatching(/orders_delay/));
   });
 
-  test('fetch table schema', async () => {
-    const schema = await queryOrchestrator.fetchSchema('foo');
-    expect(schema).toEqual(schemaData);
-  });
-
   test('streaming simple', async () => {
     const query = (id) => ({
       query: `SELECT * FROM stb_pre_aggregations.orders_d WHERE id = ${id}`,
@@ -1713,9 +1704,4 @@ describe('QueryOrchestrator', () => {
       expect(data['Foo.query']).toMatch(/orders_d/);
     }));
   });
-
-  test('fetch table schema from external db', async () => {
-    const schema = await queryOrchestrator.fetchSchema(undefined, true);
-    expect(schema).toEqual(schemaData);
-  });
 });