-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(snowflake-driver): Add support for IAM roles with IRSA for S3 export buckets #10011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2dd79a5
make keyId and secretKey optional for s3
morford-brex c8e7b93
fix handling
morford-brex 9d2ee31
lint
morford-brex 4510ac7
update docs
morford-brex e9da14b
update update-all-snapshots-local
morford-brex fc80650
add driver test to gh workflow
morford-brex fad29b1
address comments
morford-brex f5367b5
revert docs changes
morford-brex 44255ae
update validation logic
morford-brex 59aa8cb
update comments
morford-brex 666b5f2
Merge branch 'master' into morford/s3-export-iam
KSDaemon bc112d4
Merge branch 'master' into morford/s3-export-iam
KSDaemon 21f4d9b
fix storage integaration name
KSDaemon 0774c15
Configure AWS credentials via IRSA
KSDaemon 541c34b
add permissions
KSDaemon 3afae71
code format
KSDaemon 980e566
uppercase storage integration
KSDaemon 4a1dd70
enable IRSA credential mounting for containerized AWS tests
morford-brex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/cubejs-testing-drivers/test/snowflake-export-bucket-s3-iam-roles-full.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { testQueries } from '../src/tests/testQueries'; | ||
|
|
||
| testQueries('snowflake', { | ||
| // NOTICE: It's enough to turn on this flag only once for any one | ||
| // cloud storage integration. Please do not turn it on for every integration test! | ||
| includeIncrementalSchemaSuite: false, | ||
| includeHLLSuite: false, | ||
| extendedEnv: 'export-bucket-s3-iam-roles' | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.