Skip to content

chore(ci): Enable unit and integration tests for node.js v24 #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(ci): Enable unit and integration tests for node.js v24 #10101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ jobs:
strategy:
matrix:
# Current docker version + next LTS
# TODO: Add 24 after it's been released
node-version: [22.x]
node-version: [22.x, 24.x]
# Don't forget to update build-native-release
python-version: [3.11]
transpile-worker-threads: [false, true]
Expand Down Expand Up @@ -419,7 +418,7 @@ jobs:

strategy:
matrix:
node-version: [22.x]
node-version: [22.x, 24.x]
# Vertica tests are disabled because around 20.08.2025 someone
# totally removed all vertica-ce docker repository from dockerhub.
# @see https://github.com/vertica/vertica-containers/issues/64
Expand Down Expand Up @@ -523,13 +522,16 @@ jobs:
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_USER: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_USER }}
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_PASS: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_PASS }}
- name: Fix lcov paths
if: (matrix.node-version == '24.x')
run: |
./.github/actions/codecov-fix.sh
- name: Combine all fixed LCOV files
if: (matrix.node-version == '24.x')
run: |
echo "" > ./combined-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}.lcov
find ./packages -type f -name lcov.fixed.info -exec cat {} + >> ./combined-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}.lcov || true
- name: Upload coverage artifact
if: (matrix.node-version == '24.x')
uses: actions/upload-artifact@v4
with:
name: coverage-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}
Expand Down
Loading