Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps cube-js/arrow-datafusion@8e60e17, fixing an issue with joins providing extra empty rows when target_partition in DataFusion config is set to 1 and right input of the join happens to have multiple partitions (e.g. Union).

@MazterQyou MazterQyou requested review from a team as code owners October 29, 2025 17:59
@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.10%. Comparing base (d9b31e0) to head (93337f6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10105       +/-   ##
===========================================
+ Coverage   55.10%   78.10%   +22.99%     
===========================================
  Files         213      457      +244     
  Lines       16882    90994    +74112     
  Branches     3330     3330               
===========================================
+ Hits         9303    71070    +61767     
- Misses       7106    19451    +12345     
  Partials      473      473               
Flag Coverage Δ
cube-backend 55.10% <ø> (ø)
cubesql 83.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon merged commit ae32748 into master Oct 29, 2025
124 of 125 checks passed
@KSDaemon KSDaemon deleted the cubesql/join-repartition-fix branch October 29, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants