Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 6, 2025

This removes internal service cacheMode property from the query before logging it.

Check List

  • Tests have been run in packages where changes have been made, if available
  • Linter has been run for changed code

This removes internal service cacheMode property from the query before logging it.
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.14%. Comparing base (6a8ca2e) to head (9cb826f).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6a8ca2e) and HEAD (9cb826f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6a8ca2e) HEAD (9cb826f)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10120       +/-   ##
===========================================
- Coverage   78.10%   55.14%   -22.97%     
===========================================
  Files         457      213      -244     
  Lines       90997    16889    -74108     
  Branches     3330     3330               
===========================================
- Hits        71077     9314    -61763     
+ Misses      19444     7099    -12345     
  Partials      476      476               
Flag Coverage Δ
cube-backend 55.14% <100.00%> (+0.01%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review November 6, 2025 15:51
@KSDaemon KSDaemon requested a review from a team as a code owner November 6, 2025 15:51
@KSDaemon KSDaemon merged commit e8db92f into master Nov 6, 2025
38 checks passed
@KSDaemon KSDaemon deleted the fix/cache-mod-log branch November 6, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants