Skip to content

feat: Enable CUBESQL_SQL_PUSH_DOWN by default #8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat: Enable CUBESQL_SQL_PUSH_DOWN by default #8814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-backend-shared/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1633,7 +1633,7 @@ const variables: Record<string, (...args: any) => any> = {
.asInt(),

allowUngroupedWithoutPrimaryKey: () => get('CUBEJS_ALLOW_UNGROUPED_WITHOUT_PRIMARY_KEY')
.default(get('CUBESQL_SQL_PUSH_DOWN').default('false').asString())
.default(get('CUBESQL_SQL_PUSH_DOWN').default('true').asString())
.asBoolStrict(),
nodeEnv: () => get('NODE_ENV')
.asString(),
Expand Down
2 changes: 1 addition & 1 deletion rust/cubesql/cubesql/src/compile/rewrite/rewriter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ impl Rewriter {
pub fn sql_push_down_enabled() -> bool {
env::var("CUBESQL_SQL_PUSH_DOWN")
.map(|v| v.to_lowercase() == "true")
.unwrap_or(false)
.unwrap_or(true)
}

pub fn rewrite_rules(
Expand Down
2 changes: 1 addition & 1 deletion rust/cubesql/cubesql/src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ impl ConfigObjImpl {
.ok()
.map(|v| v.parse::<u64>().unwrap())
.unwrap_or(120);
let sql_push_down = env_parse("CUBESQL_SQL_PUSH_DOWN", false);
let sql_push_down = env_parse("CUBESQL_SQL_PUSH_DOWN", true);
Self {
bind_address: env::var("CUBESQL_BIND_ADDR").ok().or_else(|| {
env::var("CUBESQL_PORT")
Expand Down
Loading