Skip to content

Conversation

@gingermike
Copy link

@gingermike gingermike commented Oct 17, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Add support for Arrow Flight JDBC driver

Description of Changes Made (if issue reference is not provided)

Extended the configuration as per the contribution guide to add Arrow Flight driver

@gingermike gingermike requested a review from a team as a code owner October 17, 2024 13:43
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 17, 2024
@vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Oct 17, 2024 1:44pm
examples-react-d3 ⬜️ Ignored (Inspect) Oct 17, 2024 1:44pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:44pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:44pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:44pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:44pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Oct 17, 2024 1:44pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:44pm

@paveltiunov
Copy link
Member

@gingermike Thanks for contributing! This part just adds JDBC driver but we'd need separate driver package. Please see https://github.com/cube-js/cube/blob/master/CONTRIBUTING.md#contributing-database-drivers.

@gingermike
Copy link
Author

Thanks @paveltiunov - are you suggesting that I need to write a standalone Flight RPC implementation?

I was under the impression we could just extend the DbTypes for the JDBC driver as listed here: https://github.com/cube-js/cube/blob/master/CONTRIBUTING.md#implementing-a-jdbc-driver

The Flight SQL JDBC driver is very mature - I'm not sure how much value there would be in writing a native typescript version (that would end up having to call down to a native Rust implementation anyway)?

@paveltiunov
Copy link
Member

@gingermike Driver itself is just one part. In order to use it with Dremio for example you'd need also a dialect as it's different for every DB.

@Raven888888
Copy link

Any progress on this? We would like to enjoy the benefit of Arrow with JDBC for standard databases like Postgres, Mysql and SQL Server.

@igorlukanin
Copy link
Member

We would like to enjoy the benefit of Arrow with JDBC for standard databases like Postgres, Mysql and SQL Server.

@Raven888888 I'm pretty sure that these databases in particular can not benefit from using Arrow Flight since they are not columnar.

Also, generally, as Pavel mentioned above, this PR does not provide a data source driver as many more parts should be also implemented: https://github.com/cube-js/cube/blob/master/CONTRIBUTING.md#contributing-database-drivers

Thus, closing this PR.

@igorlukanin igorlukanin closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants