Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@waralexrom waralexrom requested review from a team as code owners October 17, 2024 18:12
@vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 9:01pm

@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (6b17731) to head (cfea277).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8832      +/-   ##
==========================================
+ Coverage   82.67%   82.69%   +0.02%     
==========================================
  Files         219      221       +2     
  Lines       78161    78609     +448     
==========================================
+ Hits        64617    65006     +389     
- Misses      13544    13603      +59     
Flag Coverage Δ
cubesql 82.69% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waralexrom waralexrom merged commit 20ed3e0 into master Oct 20, 2024
87 checks passed
@waralexrom waralexrom deleted the sql-planner-base-multi-staging-support branch October 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants