Skip to content

Conversation

@nagulan23
Copy link
Contributor

@nagulan23 nagulan23 commented Oct 20, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#4604
#718

Description of Changes Made

Opens flexibility for users to provide custom value to be filled for the missing date.

@nagulan23 nagulan23 requested a review from a team as a code owner October 20, 2024 13:32
@vercel
Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 20, 2024
@igorlukanin
Copy link
Member

Thanks for your contribution, @nagulan23 🙌

Could you also please update the docs on this page? https://cube.dev/docs/reference/frontend/cubejs-client-core

@nagulan23
Copy link
Contributor Author

@igorlukanin Have updated the doc.

@KSDaemon
Copy link
Member

KSDaemon commented Dec 13, 2024

Gentle pinging @nagulan23

@KSDaemon KSDaemon changed the title feat(cubejs-client-core): fill missing dates with custom measure value feat(cubejs-client-core): Fill missing dates with custom measure value Dec 18, 2024
@KSDaemon
Copy link
Member

@nagulan23 thank you for the contribution!

@KSDaemon KSDaemon merged commit ed3f6c9 into cube-js:master Dec 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants