Skip to content

feat(bigquery-driver): optimize testConnection() with free of charge request #8845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(bigquery-driver): optimize testConnection() with free of charge request #8845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/cubejs-bigquery-driver/src/BigQueryDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,13 @@ export class BigQueryDriver extends BaseDriver implements DriverInterface {
}

public async testConnection() {
await this.bigquery.query({
query: 'SELECT ? AS number',
params: ['1'],
jobTimeoutMs: this.testConnectionTimeout(),
});
// From the BigQuery Docs:
// You are not charged for list, get, patch, update and delete calls.
// Examples include (but are not limited to): listing datasets, updating
// a dataset's access control list, updating a table's description, or
// listing user-defined functions in a dataset.
// @see https://cloud.google.com/bigquery/pricing#free
await this.bigquery.getDatasets();
}

public readOnly() {
Expand Down
Loading