Skip to content

revert: feat(base-driver): add an option to skip connection test probes (#8833) #8846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
+0 −23
Merged

revert: feat(base-driver): add an option to skip connection test probes (#8833) #8846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/cubejs-backend-shared/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,17 +479,6 @@ const variables: Record<string, (...args: any) => any> = {
return val;
},

/**
* Flag to disable driver's test connection probes
*/
dbDisableTestConnection: ({
dataSource
}: {
dataSource: string,
}) => (
!!process.env[keyByDataSource('CUBEJS_DB_DISABLE_TEST_CONNECTION', dataSource)]
),

/**
* Database max pool size.
*/
Expand Down
12 changes: 0 additions & 12 deletions packages/cubejs-base-driver/src/BaseDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ export abstract class BaseDriver implements DriverInterface {

protected logger: any;

protected isTestConnectionDisabledFlag: boolean = false;

/**
* Class constructor.
*/
Expand All @@ -186,14 +184,8 @@ export abstract class BaseDriver implements DriverInterface {
* request before determining it as not valid. Default - 10000 ms.
*/
testConnectionTimeout?: number,

/**
* Flag for serverless DWHs to omit test connection probes.
*/
isTestConnectionDisabled?: boolean,
} = {}) {
this.testConnectionTimeoutValue = _options.testConnectionTimeout || 10000;
this.isTestConnectionDisabledFlag = _options.isTestConnectionDisabled || false;
}

protected informationSchemaQuery() {
Expand Down Expand Up @@ -688,10 +680,6 @@ export abstract class BaseDriver implements DriverInterface {
query.query = `SELECT * FROM (${query.query}) AS t LIMIT ${query.limit}`;
}

public isTestConnectionDisabled(): boolean {
return !!this.isTestConnectionDisabledFlag;
}

/**
* Returns an array of signed AWS S3 URLs of the unloaded csv files.
*/
Expand Down
Loading