Skip to content

fix(cubejs-server-core): driverError overriding #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(cubejs-server-core): driverError overriding #8852

merged 1 commit into from
Oct 22, 2024

Conversation

@johancube
Copy link
Contributor

@johancube johancube commented Oct 22, 2024 •
edited
Loading

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@johancube johancube requested a review from a team as a code owner October 22, 2024 12:53
@vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-react-highcharts ⬜️ Ignored (Inspect) Oct 22, 2024 0:54am
examples-react-material-ui ⬜️ Ignored (Inspect) Oct 22, 2024 0:54am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 22, 2024
KSDaemon
KSDaemon approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@johancube johancube merged commit b7306d2 into master Oct 22, 2024
42 checks passed
@johancube johancube deleted the fix/driver-error branch October 22, 2024 13:01
johancube added a commit that referenced this pull request Oct 22, 2024
@johancube
Revert "fix(cubejs-server-core): driverError overriding (#8852)"
2b5fb8d 
This reverts commit b7306d2.
@johancube johancube mentioned this pull request Oct 22, 2024
Merged
johancube added a commit that referenced this pull request Oct 22, 2024
@johancube
Revert "fix(cubejs-server-core): driverError overriding (#8852)" (#8854)
67eaa1c 
This reverts commit b7306d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KSDaemon KSDaemon KSDaemon approved these changes

Assignees

No one assigned

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johancube @KSDaemon