Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:19pm

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (fa4b3b8) to head (566567c).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8861   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         221      221           
  Lines       77597    77602    +5     
=======================================
+ Hits        64022    64027    +5     
  Misses      13575    13575           
Flag Coverage Δ
cubesql 82.50% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review October 24, 2024 13:01
@mcheshkov mcheshkov requested a review from a team as a code owner October 24, 2024 13:01
@mcheshkov mcheshkov force-pushed the wrapped-select-explicit-ungroup-check branch from e6de89b to 566567c Compare October 29, 2024 15:18
@mcheshkov mcheshkov merged commit 92f419c into master Oct 29, 2024
85 checks passed
@mcheshkov mcheshkov deleted the wrapped-select-explicit-ungroup-check branch October 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants