refactor(cubesql): Improve EGraph debugger, part 2: TypeScript, ELK in worker, simplify ReactFlow <-> ELK interop #8863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8863 +/- ##
==========================================
- Coverage 82.50% 82.49% -0.02%
==========================================
Files 221 221
Lines 77602 77606 +4
==========================================
- Hits 64028 64020 -8
- Misses 13574 13586 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
react-scripts does not support typescript 5, so it uses 4
According to their own typings, LayoutOptions is a string->string record
This should allow changing nodes multiple times without waiting for every zoom animation
mcheshkov
force-pushed
the
refactor-egraph-debugger-2
branch
from
8fe1bcf to
ca083c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Various improvements to EGraph debugger: