Skip to content

chore(cubestore): make trace_id and span_id suitable for open telemetry. #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 25, 2024
+296 −18
Merged

chore(cubestore): make trace_id and span_id suitable for open telemetry. #8872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f4519a1
chore(cubestore): make trace_id and span_id suitable for open telemetry.
KSDaemon Oct 28, 2024
bc75162
udpate TracingHelper trait
KSDaemon Nov 11, 2024
c1a48f7
add teardown to Configurator trait
KSDaemon Nov 11, 2024
563f09d
fix typo
KSDaemon Nov 12, 2024
33e699f
instantiate parent span in WorkerProcessing
KSDaemon Nov 12, 2024
5debf35
add opentelemetry* crates
KSDaemon Nov 12, 2024
d15aba9
cargo fmt
KSDaemon Nov 12, 2024
df5f244
simplify trace_id_and_span_id.map reinitialization
KSDaemon Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/cubestore/cubestore/src/cluster/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ use crate::queryplanner::query_executor::{QueryExecutor, SerializedRecordBatchSt
use crate::queryplanner::serialized_plan::SerializedPlan;
use crate::remotefs::RemoteFs;
use crate::store::ChunkDataStore;
use crate::telemetry::tracing::TracingHelper;
use crate::telemetry::tracing::{TraceIdAndSpanId, TracingHelper};
use crate::CubeError;
use async_trait::async_trait;
use datafusion::arrow::datatypes::SchemaRef;
Expand Down Expand Up @@ -215,7 +215,7 @@ pub enum WorkerMessage {
SerializedPlan,
HashMap<String, String>,
HashMap<u64, Vec<SerializedRecordBatchStream>>,
Option<(u64, u64)>,
Option<TraceIdAndSpanId>,
),
}

Expand Down
6 changes: 4 additions & 2 deletions rust/cubestore/cubestore/src/telemetry/tracing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,16 @@ use crate::config::injection::DIService;
use crate::CubeError;
use std::sync::Arc;

pub type TraceIdAndSpanId = (u128, u64);

pub trait TracingHelper: DIService + Send + Sync {
fn trace_and_span_id(&self) -> Option<(u64, u64)>;
fn trace_and_span_id(&self) -> Option<TraceIdAndSpanId>;
}

pub struct TracingHelperImpl;

impl TracingHelper for TracingHelperImpl {
fn trace_and_span_id(&self) -> Option<(u64, u64)> {
fn trace_and_span_id(&self) -> Option<TraceIdAndSpanId> {
None
}
}
Expand Down
Loading