Skip to content

Conversation

@shivam-mindtickle
Copy link

@shivam-mindtickle shivam-mindtickle commented Oct 29, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@shivam-mindtickle shivam-mindtickle requested a review from a team as a code owner October 29, 2024 06:13
@vercel
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:14am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 29, 2024
@shivam-mindtickle shivam-mindtickle changed the title shown: true -> public : true docs: update shown: true to public : true Oct 29, 2024
@paveltiunov
Copy link
Member

@shivam-mindtickle We'd need to fix tests for that.

@KSDaemon
Copy link
Member

KSDaemon commented Jan 7, 2025

Gentle ping @shivam-mindtickle. Could you please update the failing tests with the new message? It should be easy — just search for old messages in tests and update them with new ones!

@KSDaemon KSDaemon changed the title docs: update shown: true to public : true fix(docs): update shown: true to public : true Jan 20, 2025
@KSDaemon KSDaemon changed the title fix(docs): update shown: true to public : true fix(api-gateway): Update shown: true to public : true in error messages Jan 20, 2025
@KSDaemon
Copy link
Member

Gentle ping @shivam-mindtickle.... Could you please rebase on the fresh master and update the failing tests with the new message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants