Skip to content

Conversation

@droidraja
Copy link

@droidraja droidraja commented Nov 3, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
#8901

@droidraja droidraja requested a review from a team as a code owner November 3, 2024 07:19
@vercel
Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 4:42pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 3, 2024
@paveltiunov
Copy link
Member

@droidraja Thanks for contributing! Could you please provide at least one test for it? Thanks!

@paveltiunov paveltiunov self-assigned this Nov 3, 2024
@droidraja
Copy link
Author

droidraja commented Nov 3, 2024

@droidraja Thanks for contributing! Could you please provide at least one test for it? Thanks!

@paveltiunov, This does not work for complex queries like to_timetamp(cast(epoch_varchar as numeric(10))) which is being issued by quicksight, will add a UDF to handle the same and push the changes with tests in some time

@droidraja
Copy link
Author

@paveltiunov have added the udf and testcases, please go ahead with the review.

@droidraja droidraja force-pushed the cubesql/to_timestamp branch from 4c760e1 to 1740de2 Compare November 7, 2024 14:23
@igorlukanin
Copy link
Member

@droidraja Could you also please update the docs here? https://cube.dev/docs/reference/sql-api#data-type-formatting-functions

@droidraja
Copy link
Author

@igorlukanin This PR and the existing functionality supports evaluation of constant expression to cube time dimension filter and to_timestamp can't be applied to any columns. So it doesn't support both projection and post processing that is mentioned in the docs.

@paveltiunov please correct my understanding if there are any holes.

@KSDaemon
Copy link
Member

KSDaemon commented Oct 9, 2025

@MazterQyou WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants