fix(jdbc-driver): Log errors from connection pool factory #8903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
jdbc-driver-pool-error-logs
branch
from
ac09ff7 to
d4af87d
Compare
mcheshkov
force-pushed
the
jdbc-driver-pool-error-logs
branch
from
d4af87d to
30af2da
Compare
mcheshkov
force-pushed
the
jdbc-driver-pool-error-logs
branch
from
30af2da to
32e6748
Compare
KSDaemon
reviewed
Nov 13, 2024
KSDaemon
approved these changes
Nov 13, 2024
Member
KSDaemon
left a comment
KSDaemon
left a comment
There was a problem hiding this comment.
👍🏻 LGTM! Left one minor note
mcheshkov
force-pushed
the
jdbc-driver-pool-error-logs
branch
from
32e6748 to
805e901
Compare
generic-pool will just silently throw those away, so we should at least log them
mcheshkov
force-pushed
the
jdbc-driver-pool-error-logs
branch
from
805e901 to
59e4bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
generic-poolwill just silently throw those away, so we should at least log them