Skip to content

fix(schema-compiler): Support member alias for TD with granularity #8906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(schema-compiler): Support member alias for TD with granularity #8906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/cubejs-schema-compiler/src/adapter/BaseTimeDimension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,14 @@ export class BaseTimeDimension extends BaseFilter {
return super.aliasName();
}

// @ts-ignore
public unescapedAliasName(granularity: string) {
public unescapedAliasName(granularity?: string) {
const actualGranularity = granularity || this.granularityObj?.granularity || 'day';

const fullName = `${this.dimension}.${actualGranularity}`;
if (this.query.options.memberToAlias && this.query.options.memberToAlias[fullName]) {
return this.query.options.memberToAlias[fullName];
}

return `${this.query.aliasName(this.dimension)}_${actualGranularity}`; // TODO date here for rollups
}

Expand Down
Loading