Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@waralexrom waralexrom requested a review from a team as a code owner November 6, 2024 17:22
@vercel
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:49am

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (591a383) to head (0739858).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8919      +/-   ##
==========================================
- Coverage   82.69%   82.68%   -0.02%     
==========================================
  Files         221      221              
  Lines       78467    78472       +5     
==========================================
- Hits        64888    64882       -6     
- Misses      13579    13590      +11     
Flag Coverage Δ
cubesql 82.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waralexrom waralexrom force-pushed the sql-planner-schemas-and-refactoring branch from f62b46b to 0739858 Compare November 27, 2024 11:48
@waralexrom waralexrom merged commit d1b07f1 into master Nov 27, 2024
87 checks passed
@waralexrom waralexrom deleted the sql-planner-schemas-and-refactoring branch November 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants