use default credential provider chain for duckdb s3 access #8935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
Member
|
@GabeInDevOps Thanks for the contribution! Before it's merged, we'll need an update to docs (both for the env var reference page and the DuckDb page). Thank you in advance! |
KSDaemon
reviewed
Jan 7, 2025
Comment on lines
+1621
to
+1623
| process.env[ | ||
| keyByDataSource('CUBEJS_DB_DUCKDB_S3_USE_CREDENTIAL_CHAIN', dataSource) | ||
| ] |
Member
There was a problem hiding this comment.
It would be better to parse and return a boolean here. This will simplify further checks. Have a look at this example:
snowflakeSessionKeepAlive: ({
dataSource
}: {
dataSource: string,
}) => {
const val = process.env[
keyByDataSource(
'CUBEJS_DB_SNOWFLAKE_CLIENT_SESSION_KEEP_ALIVE',
dataSource,
)
];
if (val) {
if (val.toLocaleLowerCase() === 'true') {
return true;
} else if (val.toLowerCase() === 'false') {
return false;
} else {
throw new TypeError(
`The ${
keyByDataSource(
'CUBEJS_DB_SNOWFLAKE_CLIENT_SESSION_KEEP_ALIVE',
dataSource,
)
} must be either 'true' or 'false'.`
);
}
} else {
return true;
}
},This way, you can also control the default value if the env var is not set.
Member
|
Gentle ping @GabeInDevOps. Could you please rebase on top of the latest master and wdyt about suggested changes? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt at resolving issue #8920