Skip to content

fix(ksql-driver): Kafka, list of brokers #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
+11 −2
Merged

fix(ksql-driver): Kafka, list of brokers #9009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5218be
dev
RusovDmitriy Dec 1, 2024
50287fe
dev
RusovDmitriy Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/cubejs-ksql-driver/src/KsqlDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ export class KsqlDriver extends BaseDriver implements DriverInterface {
if (this.config.kafkaHost) {
this.kafkaClient = new Kafka({
clientId: 'Cube',
brokers: [this.config.kafkaHost],
brokers: this.config.kafkaHost
.split(',')
.map(h => h.trim()),
// authenticationTimeout: 10000,
// reauthenticationThreshold: 10000,
ssl: this.config.kafkaUseSsl,
Expand Down
9 changes: 8 additions & 1 deletion rust/cubestore/cubestore/src/streaming/kafka.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,13 @@ impl StreamingSource for KafkaStreamingSource {
let unique_key_columns = self.unique_key_columns.clone();
let seq_column_index_to_move = self.seq_column_index;
let traffic_sender = TrafficSender::new(self.trace_obj.clone());
let hosts = self
.host
.clone()
.split(",")
.filter(|s| !s.is_empty())
.map(|s| s.trim().to_string())
.collect();
let stream = self
.kafka_client
.create_message_stream(
Expand All @@ -321,7 +328,7 @@ impl StreamingSource for KafkaStreamingSource {
})
.unwrap_or(Offset::End),
),
vec![self.host.clone()],
hosts,
&self.user,
&self.password,
self.use_ssl,
Expand Down
Loading