Skip to content

Conversation

@mcheshkov
Copy link
Contributor

@mcheshkov mcheshkov commented Dec 4, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

  • Add separate cheaper error type, without backtrace and input part
  • Avoid run-time formatting to add :
  • Avoid calls to replace when strip_prefix + to_string is enough

On my laptop it gives this:

cargo bench -- rules_loading
from ~21.5 ms to ~5.5 ms

cargo test reported time for Running unittests src/lib.rs
from ~49s to ~35s

cargo test --release reported time for Running unittests src/lib.rs
from ~6.9s to ~3.5s

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (2f11d20) to head (ae6e4c8).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...st/cubesql/cubesql/src/compile/rewrite/language.rs 82.22% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9014      +/-   ##
==========================================
- Coverage   83.14%   83.14%   -0.01%     
==========================================
  Files         225      225              
  Lines       80300    80295       -5     
==========================================
- Hits        66767    66761       -6     
- Misses      13533    13534       +1     
Flag Coverage Δ
cubesql 83.14% <82.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review December 4, 2024 12:05
@mcheshkov mcheshkov requested a review from a team as a code owner December 4, 2024 12:05
@mcheshkov mcheshkov force-pushed the rules-loading-perf branch 4 times, most recently from 18aa85d to 1dd2c8c Compare January 16, 2025 13:41
* Add separate cheaper error type, without backtrace and input part
* Avoid run-time formatting to add :
* Avoid calls to replace when strip_prefix + to_string is enough
@mcheshkov mcheshkov merged commit 4cef4f0 into master Jan 16, 2025
68 checks passed
@mcheshkov mcheshkov deleted the rules-loading-perf branch January 16, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants