Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (3e203e8) to head (356dad2).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9038      +/-   ##
==========================================
- Coverage   82.68%   82.68%   -0.01%     
==========================================
  Files         221      221              
  Lines       78474    78474              
==========================================
- Hits        64890    64885       -5     
- Misses      13584    13589       +5     
Flag Coverage Δ
cubesql 82.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waralexrom waralexrom marked this pull request as ready for review December 14, 2024 01:43
@waralexrom waralexrom requested a review from a team as a code owner December 14, 2024 01:43
@paveltiunov paveltiunov changed the base branch from sql-planner-make-tests-working to master December 14, 2024 20:56
@paveltiunov paveltiunov merged commit a56462e into master Dec 14, 2024
66 checks passed
@paveltiunov paveltiunov deleted the sql-planner-another-schema-refactoring branch December 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants