Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds basic support for VALUES logical plan node in rewrite engine. Related test is included.

@MazterQyou MazterQyou requested a review from a team as a code owner December 12, 2024 13:36
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (9327f70) to head (786b1f1).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9041      +/-   ##
==========================================
+ Coverage   82.79%   82.80%   +0.01%     
==========================================
  Files         221      221              
  Lines       78527    78545      +18     
==========================================
+ Hits        65013    65037      +24     
+ Misses      13514    13508       -6     
Flag Coverage Δ
cubesql 82.80% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 368671f into master Dec 12, 2024
68 checks passed
@MazterQyou MazterQyou deleted the cubesql/values-logical-plan-language branch December 12, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants