Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Dec 16, 2024

…now and support template for params

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner December 16, 2024 21:50
@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (8ff2eca) to head (25d3f66).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9053      +/-   ##
==========================================
+ Coverage   82.79%   82.80%   +0.01%     
==========================================
  Files         221      221              
  Lines       78545    78545              
==========================================
+ Hits        65029    65037       +8     
+ Misses      13516    13508       -8     
Flag Coverage Δ
cubesql 82.80% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit cb507c1 into master Dec 16, 2024
72 of 73 checks passed
@paveltiunov paveltiunov deleted the correct-join-type branch December 16, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants