fix(schema-compiler): fix time dimension granularity origin formatting in local timezone #9071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSDaemon
force-pushed
the
chore/fix-ci-tests
branch
from
78fa69c to
36c10a3
Compare
mcheshkov
reviewed
Jan 7, 2025
Contributor
mcheshkov
left a comment
mcheshkov
left a comment
There was a problem hiding this comment.
LGTM re code changes
Changes in yarn.lock look suspicious, as if intra-repo deps have diverged, like @cubejs-backend/[email protected] in deps when we have 1.1.10 in package. But I could not find those versions in deps. Can you recreate these lockfile changes after rebase and on clean state?
Member
Author
|
@mcheshkov Without these changes in lockfile I got this error: error Invariant Violation: could not find a copy of @babel/parser to link in cube/node_modules/@cubejs-backend/dremio-driver/node_modules/@cubejs-backend/testing-shared/node_modules/@cubejs-backend/schema-compiler/node_modules
at invariant (~/.config/yarn/global/node_modules/yarn/lib/cli.js:2318:15)
at PackageLinker.<anonymous> (~/.config/yarn/global/node_modules/yarn/lib/cli.js:48524:7)
at Generator.next (<anonymous>)
at step (~/.config/yarn/global/node_modules/yarn/lib/cli.js:310:30)
at ~/.config/yarn/global/node_modules/yarn/lib/cli.js:321:13
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) |
Member
Author
|
@mcheshkov And if you noticed — there are some other internal references in lockfile (to pretty old versions)... |
KSDaemon
force-pushed
the
chore/fix-ci-tests
branch
from
36c10a3 to
4462be2
Compare
Member
Author
|
@mcheshkov Invoking |
mcheshkov
approved these changes
Jan 8, 2025
KSDaemon
added a commit
that referenced
this pull request
Feb 6, 2025
…g in local timezone (#9071) * fix integration custom granularities tests * fix postgres drivers tests related to custom granularities * fix granularity origin formatting in local timezone * fix spelling # Conflicts: # packages/cubejs-schema-compiler/src/adapter/Granularity.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect TD granularity formatting in the query timezone.
Check List