Skip to content

feat(schema-compiler): Add flag for using named timezones in MySQL Query class #9111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 24, 2025
Merged

feat(schema-compiler): Add flag for using named timezones in MySQL Query class #9111

merged 14 commits into from
Jan 24, 2025

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 17, 2025 •
edited
Loading

Remove unneeded moment-timezone dependency and use timezone names for tz conversions

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon changed the title fix(schema-compiler): get rid of moment-timezone in Query classes and correct timezone conversions feat(schema-compiler): Add flag for using named timezones in MySQL Query class Jan 17, 2025
@KSDaemon KSDaemon marked this pull request as ready for review January 17, 2025 20:35
@KSDaemon KSDaemon requested review from a team as code owners January 17, 2025 20:35
igorlukanin
igorlukanin approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@igorlukanin igorlukanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look great to me!

@KSDaemon KSDaemon merged commit 5a540db into master Jan 24, 2025
51 checks passed
@KSDaemon KSDaemon deleted the fix/queries-tz branch January 24, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paveltiunov paveltiunov paveltiunov approved these changes

@igorlukanin igorlukanin igorlukanin approved these changes

@johancube johancube johancube approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KSDaemon @paveltiunov @igorlukanin @johancube