Skip to content

Conversation

@mcheshkov
Copy link
Contributor

@mcheshkov mcheshkov commented Jan 23, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fixes #9126

Description of Changes Made (if issue reference is not provided)

Used by Metabase introspection
See metabase/metabase#50900

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 93.12977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (924a17c) to head (7da1ac0).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/udf/common.rs 55.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9129      +/-   ##
==========================================
+ Coverage   83.03%   83.05%   +0.01%     
==========================================
  Files         226      226              
  Lines       79482    79613     +131     
==========================================
+ Hits        66000    66121     +121     
- Misses      13482    13492      +10     
Flag Coverage Δ
cubesql 83.05% <93.12%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review January 23, 2025 12:39
@mcheshkov mcheshkov requested a review from a team as a code owner January 23, 2025 12:39
Used by Metabase introspection
See metabase/metabase#50900

Fixes #9126
@mcheshkov mcheshkov merged commit be140ec into master Jan 23, 2025
72 checks passed
@mcheshkov mcheshkov deleted the metabase-format-s branch January 23, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metabase SQL API Error (Unsupported format specifier %s)

4 participants