Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Allow to flatten projection node into internal WrappedSelect. This should allow to execute plans like Projection(Filter(...)) as a single ungrouped wrapper with push-to-Cube

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (ae5d977) to head (77d2848).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9165      +/-   ##
==========================================
+ Coverage   83.33%   83.40%   +0.06%     
==========================================
  Files         227      227              
  Lines       81062    81338     +276     
==========================================
+ Hits        67553    67837     +284     
+ Misses      13509    13501       -8     
Flag Coverage Δ
cubesql 83.40% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review January 31, 2025 13:42
@mcheshkov mcheshkov requested a review from a team as a code owner January 31, 2025 13:42
Allow to flatten projection node into internal WrappedSelect. This should allow to execute plans like Projection(Filter(...)) as a single ungrouped wrapper with push-to-Cube
@mcheshkov mcheshkov force-pushed the projection-flattening branch from 62c6388 to 77d2848 Compare February 10, 2025 18:02
@mcheshkov mcheshkov merged commit 8cfb253 into master Feb 10, 2025
74 checks passed
@mcheshkov mcheshkov deleted the projection-flattening branch February 10, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants