Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.57%. Comparing base (84f90c0) to head (f19de18).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...cubesql/cubesql/src/compile/rewrite/rules/utils.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9179   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         227      227           
  Lines       81627    81618    -9     
=======================================
- Hits        68216    68210    -6     
+ Misses      13411    13408    -3     
Flag Coverage Δ
cubesql 83.57% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the cubesql-bump-chrono branch 2 times, most recently from 56d4375 to 4fd5acd Compare February 17, 2025 22:16
@mcheshkov mcheshkov marked this pull request as ready for review February 17, 2025 22:21
@mcheshkov mcheshkov requested review from a team as code owners February 17, 2025 22:21
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mcheshkov mcheshkov merged commit 11dbbc3 into master Feb 18, 2025
76 checks passed
@mcheshkov mcheshkov deleted the cubesql-bump-chrono branch February 18, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants