Skip to content

fix(clickhouse-driver): Allow config http protocol to be passed to the driver. #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025
Merged

fix(clickhouse-driver): Allow config http protocol to be passed to the driver. #9195

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23a441e
fix: Allow config http protocol to be passed to clickhouse driver.
BrandonFreeman-Cavallo Feb 6, 2025
12a8888
Merge branch 'master' into fix/clickhouse-no-ssl
BrandonFreeman-Cavallo Feb 6, 2025
973474c
Merge branch 'master' into fix/clickhouse-no-ssl
KSDaemon Mar 7, 2025
b498c39
Merge branch 'master' into fix/clickhouse-no-ssl
KSDaemon Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface {
const dataSource = config.dataSource ?? assertDataSource('default');
const host = config.host ?? getEnv('dbHost', { dataSource });
const port = config.port ?? getEnv('dbPort', { dataSource }) ?? 8123;
const protocol = config.protocol ?? getEnv('dbSsl', { dataSource }) ? 'https:' : 'http:';
const protocol = config.protocol ?? (getEnv('dbSsl', { dataSource }) ? 'https:' : 'http:');
const url = `${protocol}//${host}:${port}`;

const username = config.username ?? getEnv('dbUser', { dataSource });
Expand Down