Skip to content

Conversation

@bsod90
Copy link
Member

@bsod90 bsod90 commented Feb 6, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@bsod90 bsod90 requested a review from a team as a code owner February 6, 2025 20:43
@bsod90 bsod90 force-pushed the context_to_cube_store_router_id_lts branch from a83cba3 to 5bae1fe Compare February 6, 2025 20:44
@bsod90 bsod90 requested a review from a team as a code owner February 6, 2025 20:44
@bsod90 bsod90 force-pushed the context_to_cube_store_router_id_lts branch from 5bae1fe to 7355c2a Compare February 6, 2025 20:45
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (lts/v1.0@86e49d7). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             lts/v1.0    #9199   +/-   ##
===========================================
  Coverage            ?   82.53%           
===========================================
  Files               ?      221           
  Lines               ?    77572           
  Branches            ?        0           
===========================================
  Hits                ?    64022           
  Misses              ?    13550           
  Partials            ?        0           
Flag Coverage Δ
cubesql 82.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 5213098 into lts/v1.0 Feb 7, 2025
63 of 64 checks passed
@paveltiunov paveltiunov deleted the context_to_cube_store_router_id_lts branch February 7, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants