feat: Upgrade rust to 1.84.1 (stable)

.github/workflows/cloud.yml

@@ -71,7 +71,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/drivers-tests.yml

@@ -104,7 +104,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/master.yml

@@ -55,7 +55,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/post-release.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/publish.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -95,7 +95,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -185,7 +185,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -260,7 +260,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/push.yml

@@ -72,7 +72,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -152,7 +152,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -215,7 +215,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -337,7 +337,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -414,7 +414,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -641,7 +641,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/rust-cubesql.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt, clippy
@@ -138,7 +138,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -244,7 +244,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -327,7 +327,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-07-15
+          toolchain: 1.84.1
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

packages/cubejs-backend-native/.cargo/config.toml

@@ -1,7 +1 @@
 # Please keep in sync this file with rust/cubesql!
-
-[target."x86_64-unknown-linux-gnu"]
-rustflags = ["-C", "link-arg=-fuse-ld=lld"]
-
-[target."aarch64-unknown-linux-gnu"]
-rustflags = ["-C", "link-arg=-fuse-ld=lld"]

packages/cubejs-backend-native/rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "nightly-2024-07-15"
+channel = "1.84.1"
 components = ["rustfmt", "clippy"]
-profile = "minimal"
+profile = "minimal"

packages/cubejs-backend-native/src/node_obj_deserializer.rs

@@ -41,7 +41,7 @@ impl<'a, 'b> JsValueDeserializer<'a, 'b> {
     }
 }
 
-impl<'de, 'a, 'b> Deserializer<'de> for JsValueDeserializer<'a, 'b> {
+impl<'de> Deserializer<'de> for JsValueDeserializer<'_, '_> {
     type Error = JsDeserializationError;
 
     fn deserialize_any<V>(self, visitor: V) -> Result<V::Value, Self::Error>
@@ -294,7 +294,7 @@ impl<'a, 'b> JsObjectDeserializer<'a, 'b> {
 
 // `MapAccess` is provided to the `Visitor` to give it the ability to iterate
 // through entries of the map.
-impl<'de, 'a, 'b> MapAccess<'de> for JsObjectDeserializer<'a, 'b> {
+impl<'de> MapAccess<'de> for JsObjectDeserializer<'_, '_> {
     type Error = JsDeserializationError;
 
     fn next_key_seed<K>(&mut self, seed: K) -> Result<Option<K::Value>, Self::Error>
@@ -343,7 +343,7 @@ impl<'a, 'b> JsArrayDeserializer<'a, 'b> {
 
 // `SeqAccess` is provided to the `Visitor` to give it the ability to iterate
 // through elements of the sequence.
-impl<'de, 'a, 'b> SeqAccess<'de> for JsArrayDeserializer<'a, 'b> {
+impl<'de> SeqAccess<'de> for JsArrayDeserializer<'_, '_> {
     type Error = JsDeserializationError;
 
     fn next_element_seed<T>(&mut self, seed: T) -> Result<Option<T::Value>, Self::Error>
@@ -381,7 +381,7 @@ impl<'a, 'b> JsEnumDeserializer<'a, 'b> {
 
 // `EnumAccess` is provided to the `Visitor` to give it the ability to determine
 // which variant of the enum is supposed to be deserialized.
-impl<'de, 'a, 'b> EnumAccess<'de> for JsEnumDeserializer<'a, 'b> {
+impl<'de> EnumAccess<'de> for JsEnumDeserializer<'_, '_> {
     type Error = JsDeserializationError;
     type Variant = Self;
 
@@ -394,7 +394,7 @@ impl<'de, 'a, 'b> EnumAccess<'de> for JsEnumDeserializer<'a, 'b> {
     }
 }
 
-impl<'de, 'a, 'b> VariantAccess<'de> for JsEnumDeserializer<'a, 'b> {
+impl<'de> VariantAccess<'de> for JsEnumDeserializer<'_, '_> {
     type Error = JsDeserializationError;
 
     // If the `Visitor` expected this variant to be a unit variant, the input

packages/cubejs-backend-native/src/node_obj_serializer.rs

@@ -53,7 +53,7 @@ impl<'a, 'b, C: Context<'a>> NodeObjSerializer<'a, 'b, C> {
     }
 }
 
-impl<'a, 'b, 'c, C: Context<'a>> ser::Serializer for &'c mut NodeObjSerializer<'a, 'b, C> {
+impl<'a, 'c, C: Context<'a>> ser::Serializer for &'c mut NodeObjSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
     type SerializeSeq = NodeObjSeqSerializer<'a, 'c, C>;
@@ -242,7 +242,7 @@ impl<'a, 'b, 'c, C: Context<'a>> ser::Serializer for &'c mut NodeObjSerializer<'
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeMap for NodeObjMapSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeMap for NodeObjMapSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
 
@@ -284,7 +284,7 @@ impl<'a, 'b, C: Context<'a>> ser::SerializeMap for NodeObjMapSerializer<'a, 'b,
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeTuple for NodeObjTupleSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeTuple for NodeObjTupleSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
 
@@ -299,7 +299,7 @@ impl<'a, 'b, C: Context<'a>> ser::SerializeTuple for NodeObjTupleSerializer<'a,
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeTupleStruct for NodeObjTupleSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeTupleStruct for NodeObjTupleSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
 
@@ -314,7 +314,7 @@ impl<'a, 'b, C: Context<'a>> ser::SerializeTupleStruct for NodeObjTupleSerialize
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeTupleVariant for NodeObjTupleSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeTupleVariant for NodeObjTupleSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
 
@@ -329,7 +329,7 @@ impl<'a, 'b, C: Context<'a>> ser::SerializeTupleVariant for NodeObjTupleSerializ
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeStruct for NodeObjMapSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeStruct for NodeObjMapSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
 
@@ -350,7 +350,7 @@ impl<'a, 'b, C: Context<'a>> ser::SerializeStruct for NodeObjMapSerializer<'a, '
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeStructVariant for NodeObjMapSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeStructVariant for NodeObjMapSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;
 
@@ -369,7 +369,7 @@ impl<'a, 'b, C: Context<'a>> ser::SerializeStructVariant for NodeObjMapSerialize
     }
 }
 
-impl<'a, 'b, C: Context<'a>> ser::SerializeSeq for NodeObjSeqSerializer<'a, 'b, C> {
+impl<'a, C: Context<'a>> ser::SerializeSeq for NodeObjSeqSerializer<'a, '_, C> {
     type Ok = Handle<'a, JsValue>;
     type Error = NodeObjSerializerError;