chore(fast-reload): support fastReloadEnabled as a server option #9294
Conversation
github-actions
bot
added
the
pr:community
asmisha
added
backend:server
| serverless?: boolean; | ||
| allowNodeRequire?: boolean; | ||
| semanticLayerSync?: (context: RequestContext) => Promise<BiToolSyncConfig[]> | BiToolSyncConfig[]; | ||
| fastReloadEnabled?: boolean; |
There was a problem hiding this comment.
We don't use any prefixes/suffixes for boolean options. I belive it should fastReload
|
@asmisha, you must define this option for Python configuration. Otherwise, it will not work from https://github.com/cube-js/cube/blob/v1.2.14/packages/cubejs-backend-native/python/cube/src/__init__.py |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9294 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 228 228
Lines 82016 82016
=======================================
Hits 68640 68640
Misses 13376 13376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* chore(fast-reload): support fastReloadEnabled as a server option * rename and add to python and rust
…) (#9385) * chore(fast-reload): support fastReloadEnabled as a server option * rename and add to python and rust
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]