fix(tesseract): fix wrong default alias for symbols with digits in name #9299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSDaemon
reviewed
Mar 4, 2025
|
|
||
| it('multiplied sum no dimensions through view', async () => runQueryTest( | ||
| { | ||
| measures: ['visitors_visitors_checkins_view.revenue', 'visitors_visitors_checkins_view.id_sum'], |
Member
There was a problem hiding this comment.
Do you mean revenue_1d_d1_dd or it's just another unrelated test here?)
Member
Author
There was a problem hiding this comment.
Slightly over-copying the base for the new test :). Deleted the extra
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9299 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 229 229
Lines 82658 82658
=======================================
Hits 69283 69283
Misses 13375 13375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
waralexrom
force-pushed
the
tesseract-aliases-name-fix
branch
from
b1314fb to
524bffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]