Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@waralexrom waralexrom requested a review from KSDaemon March 12, 2025 14:37
@waralexrom waralexrom requested a review from a team as a code owner March 12, 2025 14:37
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (dc5dec9) to head (8b34114).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9336   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files         229      229           
  Lines       82696    82696           
=======================================
  Hits        69267    69267           
  Misses      13429    13429           
Flag Coverage Δ
cubesql 83.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@paveltiunov paveltiunov merged commit b2c03e7 into master Mar 14, 2025
75 of 76 checks passed
@paveltiunov paveltiunov deleted the tesseract-segments branch March 14, 2025 02:14
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…e-js#9336)

* fix(tesseract): Fix error on memeber expressions working on views

* feat(tesseract): Segments and MemberExpressions segments support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants