Skip to content

[DEBUG] Add more logs to debug athena #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[DEBUG] Add more logs to debug athena #9339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70beacc
[DEBUG] Add more logs to debug athena
mcheshkov Mar 12, 2025
4b82829
[DEBUG] Add more logs to debug athena
mcheshkov Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/drivers-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,6 @@ jobs:
timeout_minutes: 20
command: |
cd ./packages/cubejs-testing-drivers
export DEBUG=testcontainers
export DEBUG=testcontainers*
yarn ${{ matrix.database }}-full

1 change: 1 addition & 0 deletions packages/cubejs-athena-driver/src/AthenaDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ export class AthenaDriver extends BaseDriver implements DriverInterface {
...(this.config.catalog != null ? { QueryExecutionContext: { Catalog: this.config.catalog } } : {})
};
const { QueryExecutionId } = await this.athena.startQueryExecution(request);
console.log('athena started query ', query, QueryExecutionId);
return { QueryExecutionId: checkNonNullable('StartQueryExecution', QueryExecutionId) };
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-testing-drivers/src/helpers/buildPreaggs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export async function hookPreaggs(
},
tokens,
);

selectors.forEach((info) => {
const { status } = info;
if (status.indexOf('failure') >= 0) {
Expand Down
9 changes: 9 additions & 0 deletions packages/cubejs-testing-drivers/src/tests/testIncrementalSchemaLoading.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ export function incrementalSchemaLoadingSuite(
});

execute('should load schemas', async () => {
const start = performance.now();
console.log('should load schemas', 'start');
const inputSchemas: QuerySchemasResult[] = await driver().getSchemas();
console.log('should load schemas', 'after getSchemas', performance.now() - start);
console.log('should load schemas', 'inputSchemas', inputSchemas);
expect(inputSchemas).toBeInstanceOf(Array);
expect(inputSchemas.length).toBeGreaterThan(0);
expect(inputSchemas).toContainEqual({
Expand All @@ -35,9 +39,14 @@ export function incrementalSchemaLoadingSuite(
});

execute('should load tables for specific schemas', async () => {
const start = performance.now();
console.log('should load tables for specific schemas', 'start');
let inputSchemas: QuerySchemasResult[] = await driver().getSchemas();
console.log('should load schemas', 'after getSchemas', performance.now() - start);
inputSchemas = inputSchemas.filter((s) => !!s.schema_name);
const inputTables = await driver().getTablesForSpecificSchemas(inputSchemas);
console.log('should load schemas', 'after getTablesForSpecificSchemas', performance.now() - start);
console.log('should load schemas', 'inputTables', inputTables);
expect(inputTables).toBeInstanceOf(Array);
expect(inputTables.length).toBeGreaterThan(0);
expect(inputTables).toContainEqual({
Expand Down