Skip to content

Conversation

@KSDaemon
Copy link
Member

This PR fixes failures during native results processing for columns with unusual data types (like json, array, etc)

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (f354570) to head (ade911c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9361   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         229      229           
  Lines       82574    82574           
=======================================
  Hits        69138    69138           
  Misses      13436    13436           
Flag Coverage Δ
cubesql 83.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review March 18, 2025 21:00
@KSDaemon KSDaemon requested a review from a team as a code owner March 18, 2025 21:00
@KSDaemon KSDaemon merged commit 1b70644 into master Mar 19, 2025
74 checks passed
@KSDaemon KSDaemon deleted the fix/result-wrapper-deser branch March 19, 2025 17:28
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* fix(backend-native): Fix result wrapper parsing

* add tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants