Skip to content

fix(redshift-driver): Use Redshift-specific schema query #9363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

fix(redshift-driver): Use Redshift-specific schema query #9363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb77e75
fix(redshift-driver): Use Redshift schema query.
emmanuel Jan 5, 2022
c6b5d5b
Merge branch 'fix/3876-redshift-schema-query' of github.com:emmanuel/…
KSDaemon Mar 19, 2025
e8020f7
fix(redshift-driver): Use Redshift-specific schema query
KSDaemon Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/cubejs-redshift-driver/src/RedshiftDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,20 @@ export class RedshiftDriver extends PostgresDriver<RedshiftDriverConfiguration>
`;
}

/**
* In Redshift schemas not owned by the current user are not shown in regular information_schema,
* so it needs to be queried through the pg_namespace table. Because user might be granted specific
* permissions on the concrete schema (like CREATE tables in already existing but not owned pre-aggregation schema).
* @override
*/
public override async createSchemaIfNotExists(schemaName: string): Promise<void> {
const schemaExistsQuery = `SELECT nspname FROM pg_namespace where nspname = ${this.param(0)}`;
const schemas = await this.query(schemaExistsQuery, [schemaName]);
if (schemas.length === 0) {
await this.query(`CREATE SCHEMA IF NOT EXISTS ${schemaName}`, []);
}
}

/**
* In Redshift external tables are not shown in regular Postgres information_schema,
* so it needs to be queried separately.
Expand Down
Loading