Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Mar 21, 2025

I am going to expose checkAuth in the next PR. To protect a situation with name collisions, I am going to rename functions that are used as checkSqlAuth.

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (a93ae85) to head (64ab466).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9372   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         229      229           
  Lines       82574    82574           
=======================================
  Hits        69138    69138           
  Misses      13436    13436           
Flag Coverage Δ
cubesql 83.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr changed the title refactor(cubesql): Use correct naming for checkSqlAuth refactor(cubesql): Use corresponding name for checkSqlAuth Mar 21, 2025
@ovr ovr marked this pull request as ready for review March 21, 2025 18:16
@ovr ovr requested a review from a team as a code owner March 21, 2025 18:16
@ovr ovr merged commit bf09dae into master Mar 21, 2025
70 checks passed
@ovr ovr deleted the refactor/native-check-sql-auth branch March 21, 2025 18:26
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
)

To protect a situation with name collisions, I renamed functions used as checkSqlAuth to checkSqlAuth instead of checkAuth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants