Skip to content

fix(schema-compiler): case insensitive filter for ClickHouse #9373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2025
Merged

fix(schema-compiler): case insensitive filter for ClickHouse #9373

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
95f02d6
Update ClickHouseQuery.ts lower() => lowerUTF8()
mironovich Mar 21, 2025
d5b28c0
Merge branch 'master' into patch-1
mironovich Apr 13, 2025
13b8b02
Merge branch 'master' into patch-1
mironovich Apr 22, 2025
6499d71
Merge branch 'master' into patch-1
mironovich Apr 30, 2025
dd46e65
Merge branch 'master' into patch-1
KSDaemon May 20, 2025
106ec3c
Merge branch 'master' into patch-1
KSDaemon Jun 6, 2025
e75b0e9
Update packages/cubejs-schema-compiler/src/adapter/ClickHouseQuery.ts
mironovich Jun 6, 2025
8122ec2
Merge branch 'master' into patch-1
KSDaemon Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-schema-compiler/src/adapter/ClickHouseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ClickHouseFilter extends BaseFilter {
public likeIgnoreCase(column, not, param, type) {
const p = (!type || type === 'contains' || type === 'ends') ? '%' : '';
const s = (!type || type === 'contains' || type === 'starts') ? '%' : '';
return `lower(${column}) ${not ? 'NOT' : ''} LIKE CONCAT('${p}', lower(${this.allocateParam(param)}), '${s}')`;
return `lowerUTF8(${column}) ${not ? 'NOT' : ''} LIKE CONCAT('${p}', lowerUTF8(${this.allocateParam(param)}), '${s}')`;
}

public castParameter() {
Expand Down
Loading