fix(schema-compiler): ExportNamedDeclaration for variables object #9390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSDaemon
force-pushed
the
arkadiusz-swierczek-pm-master
branch
from
aebb565 to
a70015f
Compare
ovr
reviewed
Apr 3, 2025
packages/cubejs-schema-compiler/src/compiler/transpilers/ImportExportTranspiler.ts
Show resolved
Hide resolved
ovr
approved these changes
Apr 3, 2025
Member
ovr
left a comment
ovr
left a comment
There was a problem hiding this comment.
Fix LGTM, but any kind of test is required!
KSDaemon
force-pushed
the
arkadiusz-swierczek-pm-master
branch
from
a70015f to
ec880ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9390 +/- ##
===========================================
- Coverage 76.57% 47.97% -28.60%
===========================================
Files 400 171 -229
Lines 105044 21424 -83620
Branches 3707 3710 +3
===========================================
- Hits 80434 10279 -70155
+ Misses 24174 10706 -13468
- Partials 436 439 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
force-pushed
the
arkadiusz-swierczek-pm-master
branch
from
ec880ca to
b1c8cf0
Compare
ovr
approved these changes
Apr 8, 2025
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…be-js#9390) * fix(schema-compiler): ExportNamedDeclaration for variables object * small fix * add tests --------- Co-authored-by: Arkadiusz Świerczek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes the original PR by @arkadiusz-swierczek-pm with some improvements/fixes.
Check List
Closes #8774