Skip to content

fix(schema-compiler): Fix model validation for aliased included members for views #9398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix(schema-compiler): Fix model validation for aliased included members for views #9398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cubejs-schema-compiler/src/compiler/CubeValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,8 +792,8 @@ const viewSchema = inherit(baseSchema, {
Joi.array().items(Joi.alternatives([
Joi.string().required(),
Joi.object().keys({
name: Joi.string().required(),
alias: Joi.string()
name: identifier.required(),
alias: identifier
})
]))
]).required(),
Expand Down
31 changes: 31 additions & 0 deletions packages/cubejs-schema-compiler/test/unit/cube-validator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,37 @@ describe('Cube Validation', () => {
expect(validationResult.error).toBeFalsy();
});

it('view with incorrect included member with alias', async () => {
const cubeValidator = new CubeValidator(new CubeSymbols());
const cube = {
name: 'name',
// it's a hidden field which we use internally
isView: true,
fileName: 'fileName',
cubes: [
{
joinPath: () => '',
prefix: false,
includes: [
'member-by-name',
{
name: 'member-by-alias',
alias: 'incorrect Alias'
}
]
}
]
};

const validationResult = cubeValidator.validate(cube, {
error: (message: any, _e: any) => {
console.log(message);
}
} as any);

expect(validationResult.error).toBeTruthy();
});

it('refreshKey alternatives', async () => {
const cubeValidator = new CubeValidator(new CubeSymbols());
const cube = {
Expand Down
Loading