-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore!: Drop support for node.js v18, deprecate v20 #9402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a619824
update "@types/node" → v20
KSDaemon fec1c11
update node-check
KSDaemon aeb39e5
add deprecation for node v20 in deprecation.md
KSDaemon 1bd4b80
update node version in ci
KSDaemon 8cac210
add todo
KSDaemon 34aab4a
update node version in docker images
KSDaemon a953137
fix node types resolutions
KSDaemon 234224c
regenerate yarn.lock
KSDaemon 86f4aa0
more comments in CI
KSDaemon 814291b
add note about v18 depr
KSDaemon 0ca6803
another type fix
KSDaemon a6a50be
upgrade angular
KSDaemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 20.19.0 | ||
| 22.14.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,36 @@ | ||
| import process from 'process'; | ||
| import color from '@oclif/color'; | ||
|
|
||
| const leastSupportedVersion = 20; | ||
| const currentNodeVersion = process.versions.node; | ||
| const semver = currentNodeVersion.split('.'); | ||
| const major = parseInt(<string> semver[0], 10); | ||
| // const _minor = parseInt(<string> semver[1], 10); | ||
|
|
||
| if (major < 18) { | ||
| if (major < leastSupportedVersion) { | ||
| console.error( | ||
| color.red( | ||
| `You are running Node.js ${currentNodeVersion}.\n` + | ||
| 'Cube.js CLI requires Node.js 20 or higher \n' + | ||
| `Cube.js CLI requires Node.js ${leastSupportedVersion} or higher.\n` + | ||
| 'Please update your Node.js version.' | ||
| ) | ||
| ); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| if (major === 19) { | ||
| if (major === (leastSupportedVersion + 1)) { | ||
| process.emitWarning( | ||
| color.red( | ||
| `You are running Node.js ${currentNodeVersion}.\n` + | ||
| 'Support for Node.js 19 not guaranty. Please upgrade to Node.js 20 or higher.' | ||
| `Support for Node.js ${leastSupportedVersion + 1} not guaranteed. Please upgrade to Node.js ${leastSupportedVersion + 2} or higher.` | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| if (major === 18) { | ||
| if (major === leastSupportedVersion) { | ||
| process.emitWarning( | ||
| color.red( | ||
| `You are running Node.js ${currentNodeVersion}.\n` + | ||
| 'Support for Node.js 18 will be removed soon. Please upgrade to Node.js 20 or higher.' | ||
| `Support for Node.js ${leastSupportedVersion} will be removed soon. Please upgrade to Node.js ${leastSupportedVersion + 2} or higher.` | ||
| ) | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.